I think jdporter has done a terrific job of analyzing this piece of code, but the one thing I see is that there is no need to load data you don't need. Just check to see that the data are between the template tags and refuse to load otherwise.

my $hash_key = undef;
while (<>) {
    if ( /^\s*<\s*TEMPLATE\s+NAME="(.*)"\s*>/i ) {
        $hash_key = $1;
        $hashref->{$hash_key} = '';
    } elsif ( /^\s*<\s*\/\s*TEMPLATE\s*>/i ) {
        $hash_key = undef;
    } elsif (defined($hash_key)) {
        $hashref->{$hash_key} .= $_;
    }
}

[download]

In reply to Re: C idioms in Perl by dwm042
in thread C idioms in Perl by slife

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.