I really should upload Test::Perl::Critic::Advisory to CPAN. It wraps all of the Perl::Critic tests in TODOs, so you still see the "failures" (and can fix them), but they don't cause the test suite to fail. And of course you can select your own priorities of what's a real problem and what isn't.

This also probably comes under "tests the author should run but the installer shouldn't have to".

However, back to the thread at hand. Perl::Critic can be valuable as a source of "hey, I should be sure I really wanted to do that" or "oops, we left a non-lexical filehandle in that code" information. I agree that blindly following every piece of its advice is no better than any other form of cargo-cult programming. But discarding the module because people are applying it wrong is, I think, overdoing it.

In reply to Re: What makes a comment "obnoxious"? by pemungkah
in thread What makes a comment "obnoxious"? by papidave

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.