girarde is correct in concluding that Anonymous Monk is completely off base in writing "If it takes so much to check that an eval worked". Adding a 1 and checking directly is a trivial amount of work.

But there is truth to "maybe something should be fixed".

Certainly, any module with a DESTROY that uses eval w/o localizing $@ should be fixed. But that also doesn't mean I'll stop protecting myself from such mistakes because fixing them when you find them doesn't mean they won't crop up again in future.

A patch to Perl that prevented a DESTROY method from clearing $@ would seem prudent to me (you probably want to allow a DESTROY to change but not clear $@ in case someone does that intentionally).

On a somewhat related point, I'd like to have @@ so that dieing inside of a DESTROY doesn't get lost: 

sub DESTROY { die "No disassemble!" }
print "($_)\n"
    for  eval { my $x= bless {}; 1 }, $@;
__END__
(1)
()

[download]

- tye        

In reply to Re^7: Question on "Effective Perl Programming" (interlude) by tye
in thread Question on "Effective Perl Programming" by jfroebe

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.