• Uses flock to handle multiple users.
• Added use strict;, which revealed many errors.
• Stopped using globals for every variable.
• Localized changes to required globals.
• Fixed bug where $filename and $filedata weren't always defined.
• Used safer 3-arg open.
• Used or instead of || when used instead of if.

use strict;
use warnings;

use Fcntl ':flock';  # Import LOCK_* constants

sub getFile {
   my $fileName = shift(@_);

   unless (defined $gotFiles->{$fileName}) {
      local $/;
      open(my $fh, '<', $fileName)
         or die;
      flock($fh, LOCK_SH)
         or die;
      $gotFiles->{$fileName} = <$fh>;
      # File handle automatically closed and unlocked here.
   }

   return $gotFiles->{$fileName};
}

sub writeFile {
   my $data = shift(@_);

   my ($filename) = $data =~ m@<filename>(.*?)</filename>@s
      or return 0;
   my ($filedata) = $data =~ m@<data>(.*)</data>@s
      or return 0;

   {
      open(my $fh, '>', "$ENV{DOCUMENT_ROOT}/$filename")
         or return 0;
      flock($fh, LOCK_EX)
         or return 0;
      print $fh $filedata; 
      # File handle automatically closed and unlocked here.
   }

   $gotFiles->{"$ENV{DOCUMENT_ROOT}/$filename"} = $filedata;
   return 1;
}
[download]

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.