also, the
trim() function does not seem correct: it is passed a parameter that is not used, has a useless for-loop, and it alters and returns the
$_ parameter (and i can't figure out what
$_ is at that point). is this really what you intend?
sub trim {
for (my $s = $_[0]) { # passed param assigned, not used
s/^\s+//; # substitutions on $_
s/\s+$//;
return $_;
}
}
instead, try something like
sub trim {
my ($string) = @_;
$string =~ s{ \A \s+ }{}xms;
$string =~ s{ \s+ \z }{}xms;
return $string;
}
also also, do not invoke a function with an ampersand, i.e., &trim($string);, unless you know what this really does. use something like trim($string); or trim(" string to be trimmed "); instead.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.