Gentle monk,

Yes, the degree of repetition is a red flag that you're working inefficiently. One of your problems is that you have a sequence of variables that aren't (programatically) connected to each other, even though their names form a series 

my $dbh = ...
my $dbh_b = ...
my $dbh2 = ...
my $dbh2_b = ...

[download]
Group these all together into a hash over which you can iterate. 
use strict;

my $db = "MyServer"; my $user = MyServerStuff::odbc->{ $db } { user };
+ my $pass = MyServerStuff::odbc->{ $db } { pass };

my %dbh;
for(my $ix= 1; $ix < 6; $ix++){
  foreach my $choice (qw(a b)){
    $dbh{$ix}{$choice} = DBI->connect("DBI:ODBC:$db",$user, $pass, {Ra
+iseError => 1})}};

[download]
For the part that generates the call to the database, wrap the code in a similar loop. Use sprintf to interpolate the '!' that switches off and on, and the varying 'from main / where main ' clauses.

throop

Updated: started $ix at 1

In reply to Re: Efficiency on Perl Code! by throop
in thread Efficiency on Perl Code! by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.