You might wanna add some sysseek's to make sure Digest::MD5 reads the whole file. Moreover, you have the outfile only opened to write (prepend a plus to the opening string of destFile.

Well, that doesn't explain the outcome of the comparison. (have to run....hint: OOP versus function)

Jeroen
"We are not alone"(FZ)

Update: I modified your code, and it works. Tested on linux. BTW, yer original code MD'd the objects! 


#!/usr/bin/perl -w
# -*-Perl-*-

use strict;
use FileHandle;
use Digest::MD5;

my $sourceFile = $ARGV[0];
my $destFile   = $ARGV[1];
my $inFile     = new FileHandle;
my $outFile    = new FileHandle;
my $inMD5      = Digest::MD5->new;
my $outMD5     = Digest::MD5->new;
my ( 
    $fileLength,
    $fileBuffer,
    $fileOffset
   );

$inFile->open ( "<$sourceFile" )
  or die "Could not open $sourceFile:$!\n";
$inMD5->addfile ( $inFile );
print $inMD5->b64digest , "\n";

$outFile->open ( "+>$destFile" )
  or die "Could not open $destFile:$!\n";

# borrowed from "Programming Perl"
die "Could not rewind $sourceFile: $!" unless defined sysseek $inFile,
+ 0, 0;


my $blockSize = ( stat $inFile )[11] || 16384;
while ( $fileLength  = sysread $inFile, $fileBuffer, $blockSize ) {
    if ( !defined $fileLength ) {
 next
   if $! =~ /^Interrupted/;
 die "System read error: $!\n";
    }
    my $fileOffset = 0;
    while ( $fileLength ) {
 my $written = syswrite $outFile, $fileBuffer, $fileLength, $fileOffse
+t;
 die "System write error: $!\n"
   unless defined $written;
 $fileLength -= $written;
 $fileOffset += $written;
    };
}
die "Could not rewind $destFile: $!" unless defined sysseek $outFile, 
+0, 0;

$outMD5->addfile ( $outFile );
print $outMD5->b64digest , "\n";

$inFile->close;
$outFile->close;

[download]
Moreover, the documented behaviour of an automagical reset right after the digest, seems not to work, at least on b64digest and my system. Something to watch for.

In reply to Re: Re: How do I verify that a copied file's contents did not corrupt/modify? by jeroenes
in thread How do I verify that a copied file's contents did not corrupt/modify? by idnopheq

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.