It don't find it very useful. It's not that it does anything bad, it's just that I don't see what value it adds. None of the "good" points hold any value for me.

I'm not sure I agree with your second "good" point anyway. For example, when using get_client_id_for_username, the programmer knows he's using EG::DB::Clients. He *should* know he's using EG::DB::Clients. That's why the methods were placed in a seperate module in the first place. Perl doesn't care if the functions are in seperate modules or not. By hiding the partitioning of the functions, you're nullifying the advantage of creating the modules in the first place.

In reply to Re^3: refactoring - is this layout a mess or should we leave well enough alone? by ikegami
in thread refactoring - is this layout a mess or should we leave well enough alone? by archimago

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.