What is it that actually bothers you with the first sub? The   return \@gencli; is about the cheapest way there is of returning an array from a sub - which one way or another is what you are doing.

I would be much more worried about the potential confusion in the mind of a reader of the code caused by overloading gencli three ways - as a sub name, a scalar containing a file name, and as an array.

Note too that using & to call a sub is generally frowned on except in a few rare special situations where the calling sub's argument list (@_) is to be passed into the called sub or you wish to ignore a sub's prototype.

The two lines:

my $gencli_scalar = gencli(); my @gencli = @{ $gencli_scalar };

might be better rewritten:

my @gencli = @{gencli()};

(although I'd use a different identifier for the array). However, generally there is probably no need to actually copy the array at all, but simply dereference the array reference returned by the sub as required.


Perl is environmentally friendly - it saves trees

In reply to Re: Extracting an array from a module by GrandFather
in thread Extracting an array from a module by jonnyfolk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.