If readability and/or maintanability is of concern, it might be of help to rephrase the code somewhat like this:
sub extract_and_add {
my ($colon_sep_string, $extra_elem) = @_;
my ($first, $second, $third, $ignore) = split( /:/, $colon_sep_str
+ing );
return join('-', $second, $third, $extra_elem);
}
Meaningful sub and variable names are really easy to set once you get into the habit - and the extra time you'll take for that will return tenfold to you in the nearest future.
Not to mention the gratitude of the first person after you that will have to look on the code without being forced to hold on breathing for a second to concentrate on "what exactly is meant here...?!"
Hth.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.