For a start the horrible nested if/else if code in the for loop can be cleaned up by using elsif (which you actually use in the while loop!):

foreach (@data) { my %ipstn_s; my %ipstn_a; next if $_->{_status} eq 'STOP'; if ( $_->{_status} eq 'START' && $_->{_i_pstn_trunk} ) { my $i_pstn_si = extract( $_->{_i_pstn_circuit}, $_->{_i_pstn_t +runk} ); push @{ $ipstn_s{$i_pstn_si} }, $_; pushnow( \%ipstn_s ); } elsif ( $_->{_status} eq 'START' ) { my $e_pstn_se = extract( $_->{_e_pstn_circuit}, $_->{_e_pstn_t +runk} ); ... pushnow( \%ipstn_a ); } else { $ncounter++; } }

Note too that $counter has been removed - it should be identical with @data used in scalar context. Also the next is handled by an if modifier which removes another level of indentation.


Perl is environmentally friendly - it saves trees

In reply to Re: help on my overall program by GrandFather
in thread help on my overall program by convenientstore

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.