I built a script which looks for files which share the same name but different extensions, and deletes dupes. I would like some advice on best programming practices.
If foo.csc, foo.txt, and bar.txt are in the same directory, and $ext is set to csc, foo.txt will be deleted (it has a csc copy), but bar.txt will be left alone. My script:
use File::Find;
my $ext = "dat";
my $nom = 0;
find ( \&ripper, @ARGV) ;
sub ripper { ## First implementation
unless(s/\.$ext$//i) {return;}
my $file = $_; #using $_ screws up grep
$nom += unlink(grep(/\Q$wang\E\.(?!$ext)/, glob("*")),"\n");
}
sub ripper2 { ## Second implementation
my $file = $_;
return unless(s/\.(?!$ext)$//i);
my $priority = $_ . $ext;
if(-e $priority && !-d $priority) { $nom += unlink $file; }
}
I wrote the second implementation because I thought it would be cleaner. Is it? Given the choice, which one would you use? Every opinion shall be gratefully recieved.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.