A suggestion on a possible code optimization:

From what you've described, you have 100,000 entries in LDAP, and 1000 entries in the file. The way your loop works, you're asking LDAP for all of the entries, and then opening the file for _each_entry_ to see if any of the lines in the file match the entry.

At a minimum -- open the file once, and generate a hash using each line in the file as a hash key -- then just test for existance in the hash. (note -- besides the issue with using '=' to compare, as already mentioned, you'll most likely also want to chomp the line to remove line endings)

Even better -- for each one of the lines in the file, extract the sn and givenName, and then do an LDAP search for entries matching those values ... yes, it's 1000 LDAP queries, but they should hopefully be relatively small, and prevent you from needing to process 100,000 records.

In reply to Re: data comparison by jhourcle
in thread data comparison by topman

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.