You should really really really really really really use an existing template module. You would have installed and learned it in the time it took you to get this question answered. Converting your templates over isn't all that hard either.

sub convert { my ($template_name) = @_; my $template; { open my $fh, '<', $template_name or die("Unable to open template file \"$template_name\": $!\ +n"); local $/; $template = <$fh>; } $template =~ s/~~\$(.+?)~~/... new syntax .../g; { open my $fh, '>', $template_name or die("Unable to overwrite template file \"$template_name\" +: $!\n"); print $fh $template; } }

At the very least, pass your variables in a hash. That will get rid of the eval EXPR and solve all scoping problems.

sub replace { my ($template_name, $params) = @_; my $template; { open my $fh, '<', $template_name or die("Unable to open template file \"$template_name\": $!\ +n"); local $/; $template = <$fh>; } $template =~ s/~~\$(.+?)~~/ if (exists($params->{$1})) { if (defined($params->{$1})) { $params->{$1} } else { warn("Template file \"$template_name\" references undefine +d variable $params->{$1}\n"); '' } } else { warn("Template file \"$template_name\" references non-existin +g variable $params->{$1}\n"); '' } /eg; print("$template\n"); } my %params = ( cell => ..., day_prev_month => ..., ); replace($template_name, \%params);

In reply to Re: lost in eval and regexp by ikegami
in thread lost in eval and regexp by lepetitalbert

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.