You can do this task all sorts of ways in perl. It is often done using what is know as "inplace editing". It is in the FAQ which are worth a look if you are new to perl. Inplace Editing shows several idioms and one liners. The classic is:

perl -pi.bak -e 's/OLDSTRING/NEWSTRING/g' FILELIST

Taking the code you have, adding some error checking and rationalising your matching regex where you capture things into $1 and $2 but do nothing with them (untested):

for my $file (@files){ open IN,"$directory/$file" or die "Can't read $directory/$file Error: $!\n"; open OUT,">$directory/$file.out" or die "Can't write $directory/$file.out Error: $!\n"; while(<IN>){ chomp; # remove newline so new data on same (?correct?) line print OUT $_; print OUT "\t\t <local-id>$file</local-id>" if /<asset-id/; print OUT "\n"; } close IN; close OUT; # now unlink IN and rename OUT to IN if desired. # warning unlink will delete the original file # unlink "$directory/$file" or die $!; # rename "$directory/$file.out", "$directory/$file" or die $!; }

This is not an elegant of perlish way of doing it but should get you heading in the right direction.


In reply to Re: output can be displayed in screen, but not in output file by tachyon-II
in thread output can be displayed in screen, but not in output file by happyrainb

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.