I guess part of your problem is that the $filename is appended to the @file_did_save array regardless of what open returns: 
if (open(OUTFILE, ... )) {
  push(@file_did_save, $filename);
} else {
  push(@did_not_save, $filename . ' ' . $!);
}

[download]
As pointed out by Anonymous Monk, the line 
$config{'image_upload_dir'}.$fntwo

[download]
should probably be 
$config{'image_upload_dir'} . '/' . $fntwo

[download]
or, even better (with File::Spec::Functions) 
use File::Spec::Functions;
catfile($config{'image_upload_dir'}, $fntwo)

[download]
which would make it platform independent (and IMHO) more readable.

I second the perltidy recommendations.

Update: Fixed typo as noted by shmem.

--
Andreas

In reply to Re: Working With Sub-Par Code by andreas1234567
in thread Working With Sub-Par Code by stonecolddevin

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.