Only a couple of style notes. while($a ne "") is better written (in this case) as while($a).

The print join(" ", @a) is almost always (as least where you're being obscure) better written as print "@a".

Improvements?

This was a pretty good first attempt. I'll only make two suggestions.

The code in the while loop b(substr($a,0,2);$a=substr($a,2); can be tightened up a bit with b $a=~/(.{2})/;$a=$'. (Hope that pasted right). The same formula can be used in b(). Since b() isn't returning a value at all, adding a shift to the very end of it, and then in the while loop saying:

   while($a) {
        $a=b $a=~/(.{2})(.*)/g;
   }

[download]

Tightens things up nicely.

This further shortens up to: 

1 while($a=b $a=~/(.{2})(.*)/g);

[download]

In reply to Re: My First JAPH - Be Gentle :-) by clintp
in thread My First JAPH - Be Gentle :-) by TStanley

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.