Looks pretty bad to me:
- Inconsistent indentation.
- Excess vertical white space.
- Excessively long variable names.
- Repeated repetition again and again of y point lookup
- Needless manipulation of parallel arrays
- Too many items returned - huge possibility for mismatched lists
- Pointless copy of input arrays
-
- Silly loop variable assignment: my $x_point = $_;. Should use for my $x_point (... instead
- Dumb keys in stupidly named hashref
I'd rework it to look something like:
sub correlation {
my ($x_ref, $y_ref) = @_;
my $lfit = Statistics::LineFit->new ();
$lfit->setData ($x_ref, $y_ref);
my ($intercept, $slope) = $lfit->coefficients ();
my $rSquared = $lfit->rSquared ();
my %results =
(intercept => $intercept, slope => $slope, rSquared => $rSquar
+ed);
foreach my $index (0 .. $#$x_ref) {
my ($xPoint, $yPoint) = ($x_ref->[$index], $y_ref->[$index]);
if ($yPoint > $intercept + ($xPoint * $slope)) {
push @{$results{above}}, [$xPoint, $yPoint];
} elsif ($yPoint < $intercept + ($xPoint * $slope)) {
push @{$results{below}}, [$xPoint, $yPoint];
} else {
push @{$results{on}}, [$xPoint, $yPoint];
}
}
return \%results;
}
Perl is environmentally friendly - it saves trees
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.