The error in your code has been already pointed out by merlyn and somebody else (how fast are these people ;-), but I'd like to add a more "idiomatic" version of your code. You should return mp3 files only (if you are after them ;-) ... 

#!/usr/bin/perl
use strict;
use warnings;
use Carp;
 
 my $dir = '/home/musc';
 my @mp3 = getSongs( $dir );

 for my $song (@mp3) {
    print "$song\n";
 }

 sub getSongs
{
 my $dir = shift;
 my @files;
 if( -d $dir ) {
    opendir(my $dirhandle, $dir) or croak "$dir $!";
    @files = grep /\.mp3$/, readdir $dirhandle;
    closedir $dirhandle
 }
 else {
    carp "don't know about $dir\n"
 }
 return @files;
}

[download]

Regards

mwa

In reply to Re: subroutine array empty by mwah
in thread subroutine array empty by davidov0009

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.