You might want to catch typos for what kind of database it is. Sure this error will be caught eventually and you will be able to track it down, but right now, if you do this: 
my $dbh = My::DB->new({server => 'foo', db => 'oops.db'})

[download]
you will get errors related to your returning of undef at the first location where you try to use the value in stead of a nice Carp saying something to the effect of "Hey, I don't know what a 'foo' database is." which will be reported for the line where the mistake actually occurs.

Try something like: 
if ($data->{server} eq 'pg') {
   ...
} elsif ($data->{server} eq 'sqlite') {
   ...
} else {
  Carp::croak "Oops, you tried to access a '$data->{server}' type data
+base, but I have no idea what that is";
}

[download]

In reply to Re: Review and Suggestions - My First Module by plobsing
in thread Review and Suggestions - My First Module by awohld

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.