I do something similar but have a sub for each type of DB - often times you need to set environmental vars, or some databases require different information passed ( or not ).

sub MSSQLConnect
{
    my $ds        = shift;
    my $db        = shift;
    my $user      = shift;
    my $pass      = shift;
    
    $ENV{SYBASE}  = '/usr/local';
    $ENV{DSQUERY} = $ds;
    
    my $dbh = DBI->connect("dbi:Sybase:database=$db",
                      $user, $pass ) or
                     return "Unable to connext to $ds: $!";
    return $dbh;
}

sub INFORMIXConnect
{
    my $server = shift;
    my $db = shift;
    #my $user   = shift;
    #my $pass   = shift;
        
    $ENV{INFORMIXSERVER} = $server;
    $ENV{ONCONFIG}       = "${server}.onconfig";
    $ENV{INFORMIXDIR}    = '/opt/informix';
    #$ENV{DBDATE}        = 'MDY4-';
    #$ENV{DBTIME}        = '%I:%M:%S';
    $ENV{PATH}           = '/usr/local/bin:/usr/bin:/bin:$ENV{INFORMIX
+DIR}/bin';
    
    my $dsn = "dbi:Informix:$db";
    my $dbh = DBI->connect("$dsn") or #, $user, $pass) or
                return "Unable to connect to $server: $!\n";
    
    return $dbh;
}

[download]
Ted
--
"That which we persist in doing becomes easier, not that the task itself has become easier, but that our ability to perform it has improved."
  --Ralph Waldo Emerson

In reply to Re: Review and Suggestions - My First Module by tcf03
in thread Review and Suggestions - My First Module by awohld

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.