Hi mbdc566021,

Your code looks like it has just been cobbled together with snippets from various sources. This is OK, but don't be afraid to make changes and experiment with the code to see what happens. Here are a few points:

• You do not need the while loop, which incidently is not completed anyway. In this context while(<READFILE>) is used to read the file line by line, but since you previously slurped the file, all of it has been read into the $filecontents variable. So a while loop is not needed here.
   
• Incrementing a hash as suggested by apl: $CharCount{$characters}++ Only works for this inside a loop structure. You are trying to combine two different techniques.
   
• You will need to experiment with your regexes to get the matches you want. If you have a copy of Programming Perl Study the chapter on Pattern Matching, and/or check the Tutorials section of Perlmonks. Also, see annotated code below:

# this matches each character once
$filecontents =~ m/./g;

# this version also puts a copy of each match into @characters
my @characters = $filecontents =~ m/./g;

# this counts the number of elements in @characters
my $CharCount = scalar @characters;

# to verify your regex is matching correctly
# this will print a list of each item counted:
for (@characters){
    print "$_ \n";
}
[download]

Good luck with your assignment.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.