There are two errors in your code.

First, your SQL statement is not syntactically correct, because you have the word GO at its end:

my $insert= $dbh->prepare("INSERT INTO $table ($columns) VALUES ($rows
+)GO");

[download]

Second, you are not properly quoting your values. Strings must be passed in (most) SQL databases surrounded by single quotes, while numbers are not allowed to have single quotes.

You should really be using placeholders so you don't need to guess as to what has to be quoted and what not and what the correct quoting characters are:

# Construct a string of "?" as the placeholders:
my $placeholders = join ",", map { "?" } keys %{$mirror{"$Itemnumber"}
+{"$table"}};
my $insert= $dbh->prepare("INSERT INTO $table ($columns) VALUES ($plac
+eholders)");
$insert->execute(values %{$mirror{"$Itemnumber"}{"$table"}});

[download]

In reply to Re: Inserting to MySQL 4.1 database using Perl DBI by Corion
in thread Inserting to MySQL 4.1 database using Perl DBI by Mr.Churka

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.