I'd suggest that instead of worrying about compressing the code, you focused on making it readable.
Good software is one that, besides running properly, is easily understandable.
update
This is not a challenge to compress the code.
The title should be 'Debug this for me'!
I rearranged the code and, instead of making it shorter, I made it longer. But still, I think it shows better what (I think) you are trying to do.
my $workDir = "/workdir";
my $oraLogin = "user/password@database";
my @filesToLoad = ( { "FileName" => 'file1.dat', "FileLoc" => 'dir1'})
+;
foreach my $fileToLoad (@filesToLoad) {
my $fileToLoadPath = "$workDir/$fileToLoad{'FileLoc'}";
opendir CTLDIR, $dileToLoadPath;
my @allFiles = readdir(CTLDIR);
closedir CTLDIR;
#my @ctlFiles = grep { /\.run_ctl/i && -f $workingDir/$_} readdir(
+CTLDIR);
#what is workingDir? aren't all .run_ctl files?
my @ctlFiles = grep { /\.run_ctl/i} @allFiles;
+
my @sqlFiles = grep { /\.run_sql/i} @allFiles;
loader($fileToLoadPath, \@ctlFiles);
loader($fileToLoadPath, \@sqlFiles);
}
sub loader {
my $path = shift;
my $fileList = shift;
foreach my $file (@{ $fileList }) {
system("sqlldr $oraLogin $path/$file rows=10000 errors=99999 $
+path/sqlldr.log");
}
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.