I've had it come it in code reviews. In order to effect the minimum amount of changes to prevent the problem, I use the following change:

my $p = $q if condition();
# becomes
my $p = condition() ? $q : undef;

[download]

This avoids introducing a second statement, such as instantiating and then assigning:

my $p; $p = $q if condition();

For the risk in this latter piece of code is that someone might "helpfully" refactor it back again. The ternary operator forces people to think about both sides of the condition.

• another intruder with the mooring in the heart of the Perl

In reply to Re: "my $p = value if condition()" as bad|deprecated as "my $p if 0" (Naughty indeed) by grinder
in thread "my $p = value if condition()" as bad|deprecated as "my $p if 0" (Naughty indeed) by parv

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.