thank you guys! I have modified my script
I am trying to make my script look better and also trying to get use to put things in subroutines(because I will need to start building larger scripts
thank you!

use strict;
use diagnostics;


sub init {
     my %total;
     while (<DATA>) {
        #my %total;        #why doesn't this work??????
        next if /^#/;
        next if /^$/;
        next if ! /(server[1-4])\s+(proc[A-Z]+)\s+(proc\.[0-9]+)\s+[0-
+9]+\s+([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+:?[0-9]{4}?)\s+.+$/;
        $total{join ("\@", $3,$1)} = "$4";
     }
return \%total;
}



sub do_something {
       my $do_it = shift;
       while (<>) {
         chomp;
         my $item = $_;
           for (keys %{$do_it}) {
           print "$_ ===> $$do_it{$_}\n" if $_ eq "$item";
         }
       }
}

do_something(init());

[download]

In reply to Re^2: i dont like the way my code looks but work by convenientstore
in thread i dont like the way my code looks but work by convenientstore

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.