Oh how many times have I seen this code crap out!

You have a race condition. flock the file while you're working on it. In order to maintain the lock, you won't be able to close and reopen the file, so you'll have to open the file using in read-write mode and use seek.

use Fcntl qw( LOCK_EX SEEK_SET ); my $flashcount_file = '/var/www/html/log/flashcount.txt'; open(my $flashcount, '+<', $flashcount_file) or die; flock($flashcount, LOCK_EX) or die; my $count = <$flashcount>; $count =~ s/^count=//; $count++; seek($flashcount, 0, SEEK_SET) or die; # Not needed in this case. truncate($flastcount, 0) or die; print $flashcount "count=$count\n";

Untested.

Note: The code assumes the file already exists.

Update: Added code.


In reply to Re^2: Writing to a New File by ikegami
in thread Writing to a New File by SillyMonk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.