Now onto the fun part: picking out stylistic miscues.

• open INPUT is traditional, it's true, but open my $inFH is far better. The traditional INPUT is global, my $inFH is lexical. For the drawbacks of global variables and the advantages of lexicals, see e.g. Conway, Perl Best Practices.
• Processing a file one line at a time is of course a good idea. The way to do it (and this is traditional) is while (my $thisLine =<$inFH>)

---

In reply to Re^2: uninitialized value error by Narveson
in thread uninitialized value error by mercuryshipz

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":





---

• Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
• Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
• Read Where should I post X? if you're not absolutely sure you're posting in the right place.
• Please read these before you post! —
  • How do I compose an effective node title?
  • How do I post a question effectively?
  • Markup in the Monastery
• Posts may use any of the Perl Monks Approved HTML tags:

  a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

• You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

  	For:		Use:
  	&		&
  	<		&lt;
  	>		&gt;
  	[		&#91;
  	]		&#93;

• Link using PerlMonks shortcuts! What shortcuts can I use for linking?
• See Writeup Formatting Tips and other pages linked from there for more info.