You push $1 onto @array (push (@array, $1);) regardless of getting a match in the previous regex. Unless the last matching line in your file is a well formed $lastPhrase line, your code as it stands will fail as you have noted.

The following test code illustrates the problem:

use strict; use warnings; use List::Util qw{first}; my $file = <<FILE; total rejected recors: 10 FILE my @phrases = ( "total rejected rows:", "total rejected recors:", "rejectb:", "total rejected rows:" ); open my $inFile, '<', \$file; my @newarray = search_phrase ($inFile, @phrases); close $inFile or die qq{close: $!\n}; $newarray[$#newarray] =~ s/\s+//g; if (@newarray && $newarray[$#newarray] > 0) { print "$newarray[$#newarray]\n"; } else { print "-1\n"; } sub search_phrase { my ($inFile, @phrases) = @_; my @array; my $lastPhrase = $phrases[-1]; my @lines = <$inFile>; foreach my $phrase (@phrases) { # Find the first match in the remaining lines for the current +phrase my $lineNo = first { $lines[$_] =~ /\Q$phrase\E/ } 0 .. $#line +s; next unless defined $lineNo; # No line containing current phra +se print "Found: $lines[$lineNo]" if ($lines[$lineNo] =~ m{\Q$lastPhrase\E\s*(\d+)}); push (@array, $1); $lineNo++; splice @lines, 0, $lineNo; # Delete processed lines } return @array; }

Perl is environmentally friendly - it saves trees

In reply to Re: uninitialized value error by GrandFather
in thread uninitialized value error by mercuryshipz

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.