Nice. Have you considered turning this into a module?

Another way to do this is to use HTML::PrettyPrinter or somesuch and do a string-wise comparision. That way it's easier to find how the code differes (using string diff tools) if needed, but it's probably a lot slower.

There's an (inherited) bug in your code. It leaks memory. You need to free the circular references in the tree by using the delete method: 

sub cmpHtml {
    ...

    my $cmp = cmpHtmlElt ($root1, $root2);

    $_->delete for $root1, $root2;

    return $cmp;
}

[download]

As a parenthesis I'd like to share this little trick: 

$cmp = EXPR;
return $cmp if $cmp;

[download]
which you use make plenty use of can be replaced with 
{ return EXPR || next }

[download]
(assuming scalar context) though that may be a bit too obfuscated to use in public code. :-)

lodin

In reply to Re: cmp two HTML fragments by lodin
in thread cmp two HTML fragments by GrandFather

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.