rename "$file_in", "$random_num"."$file_in" or warn "Couldn't rename f
+ile: $!\n";

[download]

I would put the random number at the end of the file name. Could $file_in have any slashes in it? If it does, then the path you're trying to move it to won't exist.

Also, I would simplify your code by just directly checking to see if the file exists -- no need to iterate through the directory: 

if (-e $file_in) {
    rename($file_in, "$file_in.$random_num");
}

[download]

Of course, you probably want to check if "$file_in.$random_num" already exists: 

my $f = $file_in;
while (-e $f) {
    $f = "$file_in." . int(rand(100000));
}
rename($file_in, $f);

[download]

But this doesn't protect you against race conditions - like, what if two people upload the same file at the same time. To protect against that you'll need to find an identifier that uniquely identifies this upload.

In reply to Re: Rename Uploaded File by pc88mxer
in thread Rename Uploaded File by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.