I definitely like your code better
I however, just took out the extra variable that I could just calculate later so I replaced it w/ next
results were very good
AutoLoader::__ANON__[/usr/lib/perl5/5.8.8/AutoLoader.pm:96]
Total Elapsed Time = 150.9968 Seconds
  User+System Time = 150.9268 Seconds
Exclusive Times
%Time ExclSec CumulS #Calls sec/call Csec/c  Name
 38.4   57.95 152.52      1   57.950 152.52  main::main
 34.4   52.00 50.872 194654   0.0003 0.0003  Text::CSV_XS::Parse
 14.7   22.25 21.102 194654   0.0001 0.0001  Text::CSV_XS::fields
 14.4   21.82 70.386 194654   0.0001 0.0004  Text::CSV_XS::parse
 2.79   4.207  3.086 187290   0.0000 0.0000  main::extract
 0.04   0.060  0.079      4   0.0150 0.0198  main::BEGIN
 0.01   0.010  0.010     10   0.0010 0.0010  constant::import
 0.01   0.010  0.010      2   0.0050 0.0049  Exporter::import

[download]
I also rearranged it according to yours and I got pretty good results as well
I will run it few more times to see what's going on
Also, your sample gave me good idea to get rid of some other cut+paste in the code.. Thanks!!!




sub main {
      my $csv = Text::CSV_XS->new;
      for ( @files ) {
          open  ( NOW , "$directory/$_" ) || die "you suck\n";
          while ( <NOW> ) {
                  chomp;
                  my (%rec,%HoH, $p);
                  my( $attrsRef, @selectedFields );

                  $csv->parse($_);
                  my @fields = $csv->fields;
                  ( $attrsRef, @selectedFields ) =
                       /^STOP/     ? ( \@attrs_sto, 0,1,13,14,16,20,33
+,34,36,67 )
                     : /^START/    ? ( \@attrs_sta, 0,1,11,15,28,29,31
+,53       )
                     : /^ATTEMPT/  ? ( \@attrs_att, 0,1,11,13,17,30,31
+,33,57    )
                     :                next;
                @rec{ @$attrsRef } = @fields[ @selectedFields ];
                $p =
                     $rec{ _i_pstn_trunk } ? extract( $rec{ _i_pstn_ci
+rcuit }, $rec{ _i_pstn_trunk } ) :
                     $rec{ _e_pstn_trunk } ? extract( $rec{ _e_pstn_ci
+rcuit }, $rec{ _e_pstn_trunk } ) :
                     next;
                ;
                $HoH{$p} = \%rec;
                push @data, \%HoH;
          }
          close NOW;
     }
}



Total Elapsed Time = 159.9763 Seconds
  User+System Time = 160.7492 Seconds
Exclusive Times
%Time ExclSec CumulS #Calls sec/call Csec/c  Name
 40.2   64.66 160.58      1   64.659 160.58  main::main
 34.8   56.01 54.882 194654   0.0003 0.0003  Text::CSV_XS::Parse
 13.5   21.78 20.632 194654   0.0001 0.0001  Text::CSV_XS::fields
 11.9   19.17 71.746 194654   0.0001 0.0004  Text::CSV_XS::parse
 2.90   4.667  3.546 187290   0.0000 0.0000  main::extract
 0.28   0.450  0.500      5   0.0901 0.1001  main::BEGIN
 0.02   0.040  0.031   1546   0.0000 0.0000  diagnostics::unescape
 0.01   0.010  0.010      1   0.0100 0.0099  Exporter::as_heavy
 0.01   0.010  0.010     20   0.0005 0.0005  Getopt::Long::BEGIN
 0.00   0.000 -0.000      6   0.0000      -  strict::import
 0.00   0.000 -0.000      3   0.0000      -  Text::CSV_XS::BEGIN
 0.00   0.000 -0.000      7   0.0000      -  vars::import
 0.00   0.000 -0.000      1   0.0000      -  DynaLoader::bootstrap
 0.00   0.000 -0.000      1   0.0000      -  DynaLoader::dl_load_flags
 0.00   0.000 -0.000      1   0.0000      -  DynaLoader::dl_load_file

[download]

In reply to Re^4: need to optimize my sub routine by convenientstore
in thread need to optimize my sub routine by convenientstore

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.