...Thanks only 80 more lines of code to right...

Arrgh. A classic example of why you should avoid cut and paste programming. It shouldn't be too hard to refactor all of those button calls out into one call with passed parameters. You would probably need to use a closure to get the right return values. Umm... Something like this:

(I'm working in Linux and can't use Win32::GUI stuff, so I did it with Tk, but it should give you a good hint.)

use warnings;
use strict;
use Tk;

my $font = "{Times New Roman} 32";
my @chosen;
my $grid_width = 10;

my $mw = MainWindow->new( -title => 'Keno', );

my $header_frame = $mw->Frame(
    -relief => 'raised',
    -border => 3
  )->grid(
    -row        => 0,
    -column     => 0,
    -columnspan => $grid_width,
    -sticky     => 'ew'
  );

$header_frame->Label(
    -text => 'Welcome to Keno',
    -font => "{Comic Sans MS} 24 bold",
)->pack;

my ( $row, $column );

for ( 0 .. 79 ) {
    $column = $_ % $grid_width;
    $row++ unless $column;
    $mw->Button(
        -width   => 2,
        -font    => $font,
        -text    => $_ + 1,
        -command => [ sub { Button_Click( $_[0] ) }, $_ + 1 ]
      )->grid(
        -row    => $row,
        -column => $column,
      );
}

MainLoop;

sub Button_Click {
    my $arg = shift;
    if ( defined $chosen[9] ) {
        print 'You already chose 10 numbers: ';
        print join ', ', @chosen;
        print "\n";
    }
    else {
        print "$arg was choosen\n";
        push( @chosen, $arg );
    }
}

[download]

In reply to Re^5: Subroutines not working right by thundergnat
in thread Subroutines not working right by stringplayer92

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.