First, thanks for writing the module!  As to the name, I think Unix::Lsof is fine — if anyone wants to reimplement it in pure Perl, they could still name it Unix::Lsof::Perl (which would be in line with the naming convention used with Net::SSH::Perl).

I have no definitive opinion regarding 2. and 3. (IOW, it's fine with me as you have it :), but I would personally rather avoid spaces in hash keys (4.).

Running make test on my Debian box (etch, i.e. lsof 4.77) with Perl 5.8.8 gives:

$ make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_h +arness(0, 'blib/lib', 'blib/arch')" t/*.t t/10.procedural.....ok + 5/12 skipped: Test::Exception not installed t/20.lsof-result....ok 1/50 + # Failed test 'returns true if the file exists' # in t/20.lsof-result.t at line 27. # Failed test 'Reports no errors when there aren't any' # in t/20.lsof-result.t at line 28. t/20.lsof-result....NOK 11 + # Failed test 'returns true if the file is open' # in t/20.lsof-result.t at line 34. t/20.lsof-result....NOK 12 + # Failed test 'returns true when called on process' # in t/20.lsof-result.t at line 37. t/20.lsof-result....NOK 14# Looks like you failed 4 tests of 50. + t/20.lsof-result....dubious + Test returned status 4 (wstat 1024, 0x400) DIED. FAILED tests 10-12, 14 Failed 4/50 tests, 92.00% okay (less 1 skipped test: 45 okay, +90.00%) t/pod-coverage......skipped all skipped: Test::Pod::Coverage 1.04 required for testing POD + coverage t/pod...............skipped all skipped: Test::Pod 1.14 required for testing POD Failed Test Stat Wstat Total Fail Failed List of Failed ---------------------------------------------------------------------- +--------- t/20.lsof-result.t 4 1024 50 4 8.00% 10-12 14 2 tests and 6 subtests skipped. Failed 1/4 test scripts, 75.00% okay. 4/62 subtests failed, 93.55% oka +y. make: *** [test_dynamic] Error 255

I'd be happy to provide more info (should you want it) to resolve the remaining issues... Feel free to /msg me.


In reply to Re: RFC: Unix::Lsof by almut
in thread RFC: Unix::Lsof by tirwhan

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.