Here are some thought about your code.
- Check for the success or failure of open and close operations.
- Use the three argument form of open and lexical filehandles.
- Don't keep opening and closeing your output file every time you find a line you are interested in, do them once outside the while loop. Your code keeps opening the file for writing thereby clobbering what you have written in previous loops.
- Add captures to your regex to preserve what comes before and after $element and avoid the performance implications of $'.
- Reading into $_ can save some typing as certain operations default to using $_ if no argument is given.
Something along these lines (not tested).
use strict;
use warnings;
my $element = q{coucou};
my $inFile = q{EXEMPLE.txt};
my $outFile = qq{RESEARCHED_text_${element}.txt};
open my $inFH, q{<}, $inFile
or die qq{open: $inFile: $!\n};
open my $outFH, q{>}, $ourFile
or die qq{open: $outFile: $!\n};
while ( <$inFH> )
{
next unless m{(.*?)$element(.*);
print $outFH;
my $beforeElement = $1;
my $afterElement = $2;
# Do something here with your captured text ...
}
close $inFH
or die qq{close: $inFile: $!\n};
close $outFH
or die qq{close: $outFile: $!\n};
I hope this is of use.
Cheers,
JohnGG
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.