I agree that code review has merrit. I could toss in a few spins that might be interesting as well.

Review criteria
There might be a skeleton of criteria to examine code by.

Obviously this just to mention some of the domains where by code should be reviewed.

Eligibility
I think that other areas serve the new and developing programmers well. Personally, I don't necessarily want to see reviews of yet another input form processing program.

Perhaps candidates need to accomplish *something* before being sumitted to the review queue.

Review board
Same sort of idea goes for reviewers. If someone is going to review code they need to provide constructive feedback and be skilled at not totally shredding someone else's code.

On a personal note. I have a module that I'd like to share but am anxious to do so. I have fears of total shreddage if I do so. For me, I'd like to have at least one round of private code review at which point I'll feel more comfortable with public criticisms. In my case, I'm working with someone like myself from my local Perl Mongors group.

Perhaps we could have a 1:1 mentoring mechanism with the purpose of facillitating that process.

In reply to Re: Re: Code review by jlawrenc
in thread Code review by toadi

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.