There are a few things I'd do differently, first the open I'd write as
open my $FH, '<', $file or die "Can't open $file: $!\n";
- The lexical file handle $FH is limited is scope to just the block of code it appears in so won't clobber file handles opened else where. Probably not a concern for a short script but it still a good habit.
- The three argument form of open where the open mode is specified separately is safer especially when $file comes from an untrusted source.
- I use low precedence or so I can get rid of the brackets
- I put $! in the error message so I know why the open failed.
The loop I'd rewite as this
use Data::Dumper;
my @arr;
while (<DATA>) {
chomp;
push @arr, $1 if m{^ +\s+(//.*)};
}
print Dumper \@arr;
__DATA__
// humpty dumpty
// sat on a wall
-// eating her curds and whey
// humpty dumpty
// had a great fall
which produces
$VAR1 = [
'// humpty dumpty',
'// sat on a wall',
'// humpty dumpty',
'// had a great fall'
];
Just a couple of points
- I use m{ } to avoid the leaning toothpicks.
- I use capturing parentheses to grab the bit of string I want, if there is a match it is in $1 and it is pushed onto the array
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.