$self->sis->add_event("event name");
$self->sis->log_event("message");
$self->sis->uuid();

sub sis {
    return Company::Dept->new($dbh, $uname);
}

[download]

Every time you call a method on $self->sis you're going to construct a new instance of Company::Dept, which means you might as well not bother constructing instances at all, since you'll never retrieve any instance data.

I don't fully understand what $self is in the top three statements, but here's a way to have $self->sis persist from one statement to the next:

sub sis {
    my ($self) = @_;
    
    # check whether the internal representation is already defined
    if ( !$self->{_sis} ) {
        # call the constructor and save the result
        my ($dbh, $uname) = get_constructor_args_from_somewhere();
        $self->{_sis} = Company::Dept->new($dbh, $name);
    }

    return $self->{_sis};
}

[download]

In reply to Re: OO code reuse in CGI::Application by Narveson
in thread OO code reuse in CGI::Application by Qiang

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.