The outer eval is indeed not needed. Both forms of eval catch exceptions.

As long as $suffix is constrained to /^[xismg]+\z/, there should be no security issues from the eval. There are, however, security issues with regexes, though. The following should be a good *start*: 

my $string = ...;
my $regexp = ...;
my $new    = ...;
my $suffix = ...;

my $timeout = 2;

my $output;

$suffix =~ /^[xismg]+\z/
   or die("Bad suffix\n");

my $sop = eval "sub { s/\$regexp/\$new/$suffix }";
   or die("Bad regexp: $@\n");

eval {
   local $SIG{ALRM} = sub { die "Alarm\n" };
   alarm($timeout);
   $sop->() for $output = $string;
   1
} or die("Timeout\n");

[download]

The denial of service isn't completely addressed. Even though the search is limited to $timeout seconds, the user can send requests faster than once a second.

The security risk from bugs in the regexp engine isn't addressed at all.

In reply to Re^2: unconventional string substitutions by ikegami
in thread unconventional string substitutions by halfcountplus

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.