48: open HTML, "startpage" || die "opening startpage: $!\n";
That should be or instead of ||. Common mistake which means your die will never run. This is the only serious error I found (though repeated a few times).
49: print while(<HTML>);
I was going to suggest an alternative here but I decided I actually like your method best.
50: close HTML || die "closing startpage: $!\n";
I tend to use warn rather than die when reporting a failure of close. Usually close only fails when a buffer flush fails (usually due to lack of disk space) so there are cases where you want to take more drastic action, but I don't see this as one of them.
All in all a pretty clean chunk of code.
-
tye
(but my friends call me "Tye")
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.