That will work, but... do any any other modules call Foo::Bar::do_magic, and will they work with your tinkered version? This includes the module Foo::Bar itself as well as any modules you are currently using or may use in the future. For instance, if Foo::Bar is a CPAN module, redefining do_magic can break a lot of things if your use another module which depends on the original version of the subroutine.

It is better to use sub-classing if you can: 

package My::Foo::Bar;
@ISA = qw(Foo::Bar);
sub do_magic { ... } # tinker here

[download]
and then use My::Foo::Bar instead of Foo::Bar. Now the original do_magic is preserved for those other modules which need it.

Update: use base ... is better than setting @ISA, but they accomplish the same thing.

In reply to Re: The correct way to redefine a routine by pc88mxer
in thread The correct way to redefine a routine by punkish

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.