Hi, I wrote up a simple add() and multiply() subroutine script and wanted to have it looked over. I would like it to be as efficient and correct as possible.

As it is now, it works correctly with no errors, just wanted to make sure it is proper form. Thanks for any advice.

use warnings;
use strict;

my $i = $#ARGV;

if ($ARGV[0] eq "add") {
    my $rtn = add($ARGV[1]..$ARGV[$i]);
    print "The sum is: $rtn";
}

elsif ($ARGV[0] eq "multiply"){
    my $rtn = multiply($ARGV[1]..$ARGV[$i]);
    print "Their product is: $rtn";
}

sub add {
    my ($sum);
    $sum=0;
    foreach $_(@_) {
        $sum +=$_;
    }
    return $sum;
}

sub multiply {
    my $product=1;
    foreach $_(@_) {
        $product*=$_;
    }
    return $product;
}

[download]

In reply to Simple add and multiply subroutines by negzero7

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.