Conveniently bypassing the whole code/design argument, the only thing I'd do differently is to factor out the repeated code bits (i.e., I'm Lazy about typing, as well.)

sub lbl { my $args = { -class => 'small', -for => $_[0] }; label($args, $_[1]); } sub txt { my $name = shift; my $args = { -name => $name, -id => $name }; %$args = (%$args, %{$_[0]}) if $_[0]; textfield($args); }

...which would make the invocations look like this:

# Instead of # label({-class=>'small', -for=>'ff_job_id'},'FaultFinder ID') lbl('ff_job_id','FaultFinder ID') # Instead of # textfield({-name=>'searchby_status',-id=>'searchby_status'}) txt('searchby_status') # Instead of #textfield({-name=>'searchby_date_start',-id=>'searchby_date_start',-o +nchange=>"checkDate(this)"}) txt('searchby_date_start', {-onchange => 'checkDate(this)'})

It's just a nitpick, but I have A Thing about retyping code.

Update: changed the usage/syntax of "txt" to be more like the usage of CGI (i.e., used a hashref instead of an arrayref); keeping the interface the same is a better methodology and leads to less confusion.


-- 
Human history becomes more and more a race between education and catastrophe. -- HG Wells

In reply to Re: overuse of CGI module HTML methods? by oko1
in thread overuse of CGI module HTML methods? by weedom

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.