This smells very much like homework. Most likely, ways of shortening a script have been covered in your course, but I let you in on the number one secret to shortening a script:

To shorten a script, you remove lines from it.

Most likely, you want to keep the current functionality of the script, so maybe you want to not only remove lines from it but rework other lines so you can reuse them. For example, the handling of pence, quid notes, and coins can likely be folded into one routine that takes as parameters the monetary units and the factor to multiply with. Maybe you want to store all the different money as one single number too.

In reply to Re: Can someone help me make this script more efficient by Corion
in thread Can someone help me make this script more efficient by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.