$line=~/(\w+),(\w+),(\d+),(\d+),(\d+)/;

And what happens when the regex doesn't match? don't use $1, $2, ... withouth checking that.

An alternative appraoch:

my ($firstname, $lastname, @marks) = split m/,/, $line;

This has the advantage that you can have an arbitrary number of marks. Of course you'll need to adjust the rest of the code a bit, for example;

$totalmarks = 0; $totalmarks += $_ for (@marks);
foreach $mark(@marks){ $status=checkpass($mark); }

So $status is the status of the last mark only. Is that what you want?

You should test your script also with data of failing students.

BTW I strongly recommend to align the code better, one tab for each opening brace.


In reply to Re: Students Rank calculation for the below perl script by moritz
in thread Students Rank calculation for the below perl script by valavanp

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.