1. You are pushing an undefined value $random instead of $firstrandom
  2. You are checking for string equality with == instead of cmp
  3. There was a semicolon missing.
properly: 
$firstrandom = $list1[rand @list1];
push @list2, $firstrandom;
$count = $#list1;
while ($count != 0) {    ###create list2
  $random = $list1[rand @list1];
  $ispresent = 'false';
  for $I (0..$#list2){        ##check to see if team is already in lis
+t2
    if ($random == $list2[$I]) {
      $ispresent = 'true'
    };               
  };
  if($ispresent eq 'false') { ##if not add it to @list2
    push @list2, $random;
    $count--;
  };
};

[download]

You are building a randomized version of @list1. The most efficient way of randomly shaking up a list like this is the Fisher-Yates shuffle:

Fisher-Yates (from the Perl Cookbook from O'Reilly): 

# fisher_yates_shuffle( \@array ) : generate a random permutation
# of @array in place
sub fisher_yates_shuffle {
    my $array = shift;
    my $i;
    for ($i = @$array; --$i; ) {
        my $j = int rand ($i+1);
        next if $i == $j;
        @$array[$i,$j] = @$array[$j,$i];
    }
}

fisher_yates_shuffle( \@array );    # permutes @array in place

[download]

In reply to Re: syntax issues by Vondikall
in thread syntax issues by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.