Let's start by eliminating unnecessary steps and by not storing more values into memory than necessary. By getting rid of the fluff, you might be able to see the problem and solution more clearly.
#!/usr/bin/perl
use strict;
use warnings;
my %histogram = map { $_ => 0 } qw(
a am an and are as at be been but by can co de do due each
); # hash of the words to find so we can do an O(1) lookup for them
while ( <> ) {
chomp;
for ( split ) {
# split returns a list we can use directly
$histogram{ $_ }++ if exists $histogram{ $_ };
# only store counts for words that matter
}
}
foreach my $word ( keys %histogram ) {
# keys() will list the keys, and we've already taken care
# of making sure we don't have extra words stored.
# Now there's no need to do two loops and check an array
# against a hash.
print "Found $word, $histogram{$word} times.\n";
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.