Concurring with the RaiseError, placeholder, and code tag suggestions, let me also note that there's no need to call finish on DML statements (inserts and updates).

Here's what your code will look like if you follow the advice above:

my @fields = qw( ict_category ict_type ict_subtype ict_instance ict_assign2_grp ict_severity_lvl ict_date ); my @placeholders = map {'?'} @fields; { local $" = ','; $sqlwi = "INSERT INTO $ICT (@fields) VALUES(@placeholders)"; } $dbh->{RaiseError} = 1; eval { my $sth = $dbh->prepare($sqlwi); $sth->execute( $a_catg, $a_type, $a_styp, $a_inst, $a_agrp, $a_sevl, $dat3, ); }; if ($@) { # unable to insert, error message is in $@ ... }

In reply to Re: Capturing SQL errors in Perl by Narveson
in thread Capturing SQL errors in Perl by Red_Dragon

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.