I don't think the former has less "action at a distance", on the contrary — though theorists may disagree with my terminology. In the former, you calculate the attributes, but you don't set them in init; you actually set the attributes in new. There, you depend on the specific order the attribute values are returned. That is bad: you split a logical action (setting attributes) between two tightly bound subs. Add or remove one attribute, and you have to modify both subs, and very strictly in sync. That is what makes it bad for maintenance. Surely it's better to do it all just in one place, in one single sub?

Besides, re "action at a distance", that applies to setting global variables, but that's not the case here, as you alter an object you pass as a read/write parameter.

If you insist on turning init into a function, at least, make it return a hash. 

sub my_init {
  my ($self, $args) = @_;
  # do stuff with $args;
  return { attr_1 => $attr_1, attr_2 => $attr_2 };
}

sub new {
  my ($class, $args) = @_;
  my $self = {};
  bless ($self, $class);
  my $attrs = $self->my_init($args);
  foreach (keys %$attrs) {
    $self->{$_} = $attrs->{$_};
  }
  return $self;
}

[download]
At least it breaks the internal dependency on which attributes, and in what order, are returned.

I still prefer directly setting the attributes for the object you passed as a parameter. It smells cleaner to me: there's far less distracting "janitor code" in it. (That is code that is necessary for an implementation but actually doesn't do much useful for its perceived complexity; where nothing specifically applies to this particular piece of code. Up to 4 lines of code for a simple "copy attributes" action: ugh.)

In reply to Re: Passing object attributes around by bart
in thread Passing object attributes around by wfsp

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.