There are some unclear parts in your code, we don't know how your data looks like (so there may be any kind of problem).

You should alwyas open one file after another and do all the work in one file at once. I reorganized your code (out of the blue, don't know your data) - maybe thats a new starting point.

...
my $echo = 'ECHO';
my ($dffname, $listname) = @ARGV;
my $fh;

# read key/val lists
open $fh, '<', $dffname or die "$dffname $!";
my %lijst = map { chomp; (split /\t|\s{2,}/)[1,0] } <$fh>;
close $fh;

# readfile list
open $fh, '<', $listname or die "$listname $!";
my @listfiles = <$fh>; chomp @listfiles;
close $fh;

for my $file (@listfiles) {
   # read original file
   open $fh, '<', $file or die "$file $!";
   local $/;  my $content = <$fh>;
   close $fh;

   # modify content
   while( my ($key, $val) = each %lijst ) {
      next unless $val == 1;
      $content =~ s/^$key$/$echo/gms;
      $content =~ s/^$key$/$echo/;   # re-subsitute first (?)
   }
   # write modified file
   open $fh, '>', "$file.out" or die "$file.out $!";
   print $fh $content
}
...

[download]

Regards

mwa

In reply to Re: problem with string substitution output by mwah
in thread problem with string substitution output by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.